fix default exported classes without a name #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correctly requeues class without name so the es3 transform can transform the default keyword.
Current coverage is 88.32% (diff: 100%)
|
|
|
||
| // Manualy re-queue `export default class {}` expressions so that the ES3 transform | ||
| // has an opportunity to convert them. Ideally this would happen automatically from the | ||
| // replaceWith above. See T7166 for more info. |
There was a problem hiding this comment.
Should we link to the github issue now?
hzoo
added
the
PR: Bug Fix 🐛
|
👍 |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* fix default exported classes without a name This correctly requeues class without name so the es3 transform can transform the default keyword. * Replace phabricator issue number with github
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this
will be transformed to
although the es3-literal transform is active.
Basically a followup of #3368 that @loganfsmyth did.
The fix does the same as for variables and requeues them.
Also added tests for all combinations of
export default.