Fix issue with minified libraries and code coverage #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix queue size
Current coverage is 88.34% (diff: 100%)@@ master #4534 diff @@
==========================================
Files 194 194
Lines 13621 13664 +43
Methods 1427 1439 +12
Messages 0 0
Branches 3150 3164 +14
==========================================
+ Hits 12033 12072 +39
- Misses 1588 1592 +4
Partials 0 0
|
|
Not really sure about doing this - is there a particular reason you are running babel on a minified library? |
|
It became part of a web pack bundle in some good ole legacy code... We used this as an excuse to get rid of the file, but it would be nice if this were an actually insane high number, but not a deal breaker if it doesn't get merged in. ;) |
|
This seems fine to me, what's one arbitrary limit vs another, as long as we have it. |
hzoo
added
the
PR: Bug Fix 🐛
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this issue where including a minified file (specifically -- https://github.com/googlei18n/libphonenumber) was causing it to think it should bail while calculating code coverage for our app. Raising the number to an insane depth (10,000) vs a slightly insane (but easily reachable) depth erased this problem.