Add support for preset organization shortcuts #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
commented
Sep 21, 2016
| presets: ["@babel/es2015"] | ||
| }); | ||
| }, | ||
| /Couldn\'t find preset \"\@babel\/babel\-preset\-es2015\" relative to directory/ |
There was a problem hiding this comment.
Not the best test but the error is correct
hzoo
added
the
PR: New Feature 🚀
danez
reviewed
Sep 21, 2016
| @@ -261,6 +261,18 @@ export default class OptionManager { | |||
| try { | |||
| if (typeof val === "string") { | |||
| presetLoc = resolve(`babel-preset-${val}`, dirname) || resolve(val, dirname); | |||
There was a problem hiding this comment.
babel-preset-${val} will never be a valid name if val contains an @, but I think doing a check if it contains an @ and then doing different things makes it even more complex and it works right now anyway.
danez
approved these changes
Sep 21, 2016
Current coverage is 88.35% (diff: 100%)@@ master #4542 diff @@
==========================================
Files 194 194
Lines 13621 13628 +7
Methods 1427 1427
Messages 0 0
Branches 3150 3152 +2
==========================================
+ Hits 12033 12041 +8
+ Misses 1588 1587 -1
Partials 0 0
|
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* add support for @org shortcats, fixes babel#4362 * add shortcut test * fixes
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4482, by @nkt
It doesn't let me fix merge conflicts from the website or push the branch up from my terminal so made this.