Remove duplicate default error #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
duplicate-exports
branch
from
3045e16
to
ab271d8
Compare
Current coverage is 88.35% (diff: 100%)@@ master #4543 diff @@
==========================================
Files 194 194
Lines 13628 13624 -4
Methods 1427 1427
Messages 0 0
Branches 3152 3151 -1
==========================================
- Hits 12041 12037 -4
Misses 1587 1587
Partials 0 0
|
kaicataldo
changed the title
danez
added
the
PR: Internal 🏠
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Revert "Throw error for multiple exports default (babel#3518)" This reverts commit aa51dd4. * Fix export default tests
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #4538, I reverted my initial commit that added the duplicate exports default warning, since that will now happen in the parser. I then updated the tests so they all follow the same naming convention as the one used in my most recent PR that was merged today. From the previous issue:
Let me know if there's anything else I can do!