Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: cancel build with only .md changes #4547

Merged
merged 1 commit into from Sep 22, 2016
Merged

Internal: cancel build with only .md changes #4547

merged 1 commit into from Sep 22, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Sep 22, 2016

got linked to facebook/react#2000 by @RReverser from @taion

@codecov-io
Copy link

Current coverage is 88.35% (diff: 100%)

Merging #4547 into master will not change coverage

@@             master      #4547   diff @@
==========================================
  Files           194        194          
  Lines         13624      13624          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3151       3151          
==========================================
  Hits          12037      12037          
  Misses         1587       1587          
  Partials          0          0          

Powered by Codecov. Last update 1db8c02...1f9135c

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 22, 2016
@hzoo hzoo merged commit d7533e8 into master Sep 22, 2016
@hzoo hzoo deleted the hzoo-patch-2 branch September 23, 2016 04:49
@hzoo
Copy link
Member Author

hzoo commented Sep 23, 2016

Ok this doesn't seem to be working - actually not on this commit either - everything is skipped

@@ -5,6 +5,15 @@ language: node_js
cache:
directories:
- node_modules
before_install:
- |
if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean !=?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like none of that machinery should be required any more: facebook/react@08b1515

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only time we ran into this is when there's a branch being tested. PRs worked perfectly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't seem to work without the check but i'l test again #4556

panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants