New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: cancel build with only .md changes #4547
Conversation
Current coverage is 88.35% (diff: 100%)@@ master #4547 diff @@
==========================================
Files 194 194
Lines 13624 13624
Methods 1427 1427
Messages 0 0
Branches 3151 3151
==========================================
Hits 12037 12037
Misses 1587 1587
Partials 0 0
|
Ok this doesn't seem to be working - actually not on this commit either - everything is skipped |
@@ -5,6 +5,15 @@ language: node_js | |||
cache: | |||
directories: | |||
- node_modules | |||
before_install: | |||
- | | |||
if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean !=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like none of that machinery should be required any more: facebook/react@08b1515
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only time we ran into this is when there's a branch being tested. PRs worked perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it didn't seem to work without the check but i'l test again #4556
got linked to facebook/react#2000 by @RReverser from @taion