Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes T2299: Prevent REPL from printing implicit 'use strict' #4562

Merged
merged 3 commits into from Sep 26, 2016
Merged

Fixes T2299: Prevent REPL from printing implicit 'use strict' #4562

merged 3 commits into from Sep 26, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Sep 24, 2016 •
edited

Old PR #3360 @eetulatja @loganfsmyth

./babel-node.js
> var a =1
undefined
> var a = 1;
undefined
> 'use strict';
undefined
> 'use strict'; var b = 1;
undefined
> 1+1
2

@hzoo hzoo changed the title Eetulatja master Fixes T2299: Prevent REPL from printing implicit 'use strict' Sep 24, 2016
@hzoo hzoo mentioned this pull request Sep 24, 2016
Closed
@codecov-io
Copy link

codecov-io commented Sep 24, 2016 •
edited

Current coverage is 88.47% (diff: 100%)

Merging #4562 into master will not change coverage

@@             master      #4562   diff @@
==========================================
  Files           192        192          
  Lines         13491      13491          
  Methods        1412       1412          
  Messages          0          0          
  Branches       3126       3126          
==========================================
  Hits          11936      11936          
  Misses         1555       1555          
  Partials          0          0

Powered by Codecov. Last update a832620...b9e77c2

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Sep 24, 2016
@loganfsmyth
Copy link
Member

Looks good to me.

@hzoo hzoo merged commit fc2b3cb into master Sep 26, 2016
@hzoo hzoo deleted the eetulatja-master branch September 29, 2016 12:42
@hzoo hzoo mentioned this pull request Dec 14, 2016
Closed
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@hzoo @panagosg7
Fixes T2299: Prevent REPL from printing implicit 'use strict' (babel#…
54e7acf 
…4562)

* Fixes T2299: Prevent REPL from printing implicit 'use strict'

* Test for T2299

* make fixes
@renovate renovate bot mentioned this pull request Jul 25, 2018
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hzoo @codecov-io @loganfsmyth @eetulatja