Fix fileName options passed to babylon #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filename options used by babylon is called `sourceFilename` and not `filename`. Therefore the option should be adjusted to be called `sourceFilename`.
Current coverage is 88.69% (diff: 100%)@@ master #4570 diff @@
==========================================
Files 192 192
Lines 13608 13608
Methods 1412 1412
Messages 0 0
Branches 3136 3136
==========================================
Hits 12070 12070
Misses 1538 1538
Partials 0 0
|
danez
added
the
PR: Bug Fix 🐛
|
Thank you, seems that |
|
Yeah file name is not used but somehow the unit tests break if the filename property is removed |
|
I created a new issue for that #4571 |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
The filename options used by babylon is called `sourceFilename` and not `filename`. Therefore the option should be adjusted to be called `sourceFilename`.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename options used by babylon is called
sourceFilenameand notfilename. Therefore an additional option called sourceFilename should be passed to babylon parse babel/babylon@bb49195