babel-code-frame: Highlight strings with green (not red) #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Red makes it look like something is wrong with the string. - On Ubuntu-based systems, it looks kinda broken. - The error markers (`>` and `^`) as well as invalid tokens are already marked with red. By not having strings red, the most important information -- the error location -- is more visible. This is a continuation of commit fa1de5c (PR babel#4572).
Current coverage is 88.68% (diff: 100%)@@ master #4579 diff @@
==========================================
Files 192 192
Lines 13649 13649
Methods 1414 1414
Messages 0 0
Branches 3151 3151
==========================================
Hits 12105 12105
Misses 1544 1544
Partials 0 0
|
hzoo
added
the
PR: Polish 💅
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
- Red makes it look like something is wrong with the string. - On Ubuntu-based systems, it looks kinda broken. - The error markers (`>` and `^`) as well as invalid tokens are already marked with red. By not having strings red, the most important information -- the error location -- is more visible. This is a continuation of commit fa1de5c (PR babel#4572).
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>and^) as well as invalid tokens are alreadymarked with red. By not having strings red, the most important
information -- the error location -- is more visible.
This is a continuation of commit fa1de5c (PR #4572).
Before:
After: