Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude super from being assign to ref variable #4642

Merged
merged 1 commit into from Oct 4, 2016
Merged

Exclude super from being assign to ref variable #4642

merged 1 commit into from Oct 4, 2016

Conversation

danez
Copy link
Member

@danez danez commented Oct 2, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #4349
License MIT
Doc PR

Assigning of super is not allowed var ref = super; This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned to a variable.

Assigning of super is not allowed `var ref = super;` This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned.
@danez danez added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Oct 2, 2016
@danez danez changed the title Exclude super from being assign Exclude super from being assign to ref variable Oct 2, 2016
@codecov-io
Copy link

codecov-io commented Oct 2, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4642 into master will increase coverage by <.01%

@@             master      #4642   diff @@
==========================================
  Files           195        195          
  Lines         13775      13777     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3173       3174     +1   
==========================================
+ Hits          12227      12229     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update e50b3c8...d9dd01c

@hzoo hzoo merged commit 2dcee25 into babel:master Oct 4, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
Assigning of super is not allowed `var ref = super;` This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned.
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants