Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed bool to boolean as well as updated tests #4646

Merged
merged 1 commit into from Oct 3, 2016

Conversation

sugargreenbean
Copy link
Contributor

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

issue 4584: Changed Flow value of bool to boolean and updated associated flow tests.

@codecov-io
Copy link

codecov-io commented Oct 3, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4646 into master will not change coverage

@@             master      #4646   diff @@
==========================================
  Files           195        195          
  Lines         13775      13775          
  Methods        1425       1425          
  Messages          0          0          
  Branches       3173       3173          
==========================================
  Hits          12227      12227          
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update 5de1fea...faa6f2c

@hzoo
Copy link
Member

hzoo commented Oct 3, 2016

Cool looks like all tests/linting passed

@hzoo hzoo merged commit c57e0e8 into babel:master Oct 3, 2016
@hzoo
Copy link
Member

hzoo commented Oct 3, 2016

Awesome, nice job there @sugargreenbean!

Next time you can also add Fixes #issue-number which will auto close the issue associated with the PR. Also can reference an issue with a # - #4584. (Although I realize I can just do it to when merging so no worries)

@hzoo hzoo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Polish 💅 A type of pull request used for our changelog categories and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Oct 24, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants