Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when constructor default arg refers to self or own static property #4666

Merged
merged 1 commit into from Oct 5, 2016

Conversation

danharper
Copy link
Member

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets #4253, #4442
License MIT
Doc PR reference to the documentation PR, if any

They currently throw Cannot call a class as a function due to being incorrectly wrapped in an IIFE.

@codecov-io
Copy link

codecov-io commented Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4666 into master will increase coverage by <.01%

@@             master      #4666   diff @@
==========================================
  Files           195        195          
  Lines         13776      13782     +6   
  Methods        1425       1426     +1   
  Messages          0          0          
  Branches       3174       3176     +2   
==========================================
+ Hits          12228      12234     +6   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update fc54264...53426d2

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Nice.

@danez danez added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Oct 5, 2016
@hzoo hzoo merged commit 33eb56a into babel:master Oct 5, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants