Fix block scoping transform for declarations in labeled statements #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.78% (diff: 100%)@@ master #4669 diff @@
==========================================
Files 195 195
Lines 13780 13782 +2
Methods 1425 1426 +1
Messages 0 0
Branches 3174 3173 -1
==========================================
+ Hits 12235 12237 +2
Misses 1545 1545
Partials 0 0
|
motiz88
added
the
PR: Bug Fix 🐛
danez
approved these changes
Oct 5, 2016
| if (isBlockScoped(node)) { | ||
| convertBlockScopedToVar(path, node, block, this.scope); | ||
| } | ||
| declarators = declarators.concat(node.declarations || node); |
There was a problem hiding this comment.
If we are already deduplicating code, then we maybe can also deduplicate this if? as it basically twice in here I think.
There was a problem hiding this comment.
Yeah is this equiv?
const addDeclarationsFromChild = (path, node) => {
node = node || path.node;
if (t.isLabeledStatement(node)) {
node = node.body;
path = path.get("body");
}
if (t.isClassDeclaration(node) || t.isFunctionDeclaration(node) || isBlockScoped(node)) {
if (isBlockScoped(node)) {
convertBlockScopedToVar(path, node, block, this.scope);
}
declarators = declarators.concat(node.declarations || node);
}
};There was a problem hiding this comment.
👍 Did something similar in d276d57. CI is being fussy though: https://travis-ci.org/babel/babel/jobs/165258111#L161
Grumble grumble. Let me try rebasing to latest master.
motiz88
force-pushed
the
block-scoping-and-labels
branch
from
d276d57
to
14baf0a
Compare
hzoo
approved these changes
Oct 5, 2016
|
👍 |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
…abel#4669) * Fix block scoping transform for declarations in labeled statements (babel#4122) * DRY block-scoping
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLetReferencesbetween block and switch handling;LabeledStatementnodes when collecting block-scoped declarations to transform.