Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain return types on ObjectMethods in transform-es2015-shorthand-properties #4670

Merged
merged 1 commit into from Oct 5, 2016

Conversation

danharper
Copy link
Member

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

Similar to #4668. Found ObjectMethods transformed with es2015-shorthand-properties weren't retaining the return types either.

@codecov-io
Copy link

codecov-io commented Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4670 into master will increase coverage by <.01%

@@             master      #4670   diff @@
==========================================
  Files           195        195          
  Lines         13778      13780     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3174       3174          
==========================================
+ Hits          12230      12232     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update 7f772e9...1c86926

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Oct 5, 2016
@hzoo
Copy link
Member

hzoo commented Oct 5, 2016

Awesome, good catch

@hzoo hzoo merged commit 9e17aaf into babel:master Oct 5, 2016
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants