Handle side effects correctly in rest params index expressions (#4348) #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.82% (diff: 100%)@@ master #4674 diff @@
==========================================
Files 195 195
Lines 13780 13786 +6
Methods 1425 1425
Messages 0 0
Branches 3174 3175 +1
==========================================
+ Hits 12235 12246 +11
+ Misses 1545 1540 -5
Partials 0 0
|
motiz88
added
the
PR: Bug Fix 🐛
hzoo
approved these changes
Oct 5, 2016
hzoo
reviewed
Oct 5, 2016
| var _ref; | ||
|
|
||
| var index = 0; | ||
| return _ref = index++ + 0, arguments.length <= _ref ? undefined : arguments[_ref]; |
There was a problem hiding this comment.
looks good? wondering where index++ + 0 is coming from (not part of this particular change)
There was a problem hiding this comment.
It's the index of the rest parameter in the parameter list. If the function signature were e.g. function(a, b, ...values), it would be index++ + 2 instead.
There was a problem hiding this comment.
I see, so we could make a change so that if it's 0 then don't add the + 0
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
scope.isPureheuristic to detect possible side effects of the constructed index expression, avoiding double execution as in #4348.