Update babel parser options #4688
Conversation
Current coverage is 88.83% (diff: 100%)@@ master #4688 diff @@
==========================================
Files 195 195
Lines 13794 13794
Methods 1427 1427
Messages 0 0
Branches 3176 3176
==========================================
Hits 12254 12254
Misses 1540 1540
Partials 0 0
|
| plugins: [] | ||
| allowImportExportEverywhere: this.opts.allowImportExportEverywhere, | ||
| allowReturnOutsideFunction: this.opts.allowReturnOutsideFunction, | ||
| allowSuperOutsideMethod: this.opts.allowSuperOutsideMethod, |
There was a problem hiding this comment.
did you try if you can set this options? I think that the OptionsManager would throw an Error when trying to set these options in e.g babel.transform(code, { allowImportExportEverywhere: true }) because it does not know the options. So maybe we should only set sourceType, sourceFilename and plugins here because the rest of the options could now be set via the new parserOpts option anyway. https://github.com/babel/babel/blob/master/CHANGELOG.md#rocket-new-feature-1
There was a problem hiding this comment.
Same also applies for the strictMode I think.
There was a problem hiding this comment.
You're right, not sure why I thought it worked before. Updated!
There was a problem hiding this comment.
Yep I was going to mention that too - if there are invalid might as well not use them and get everyone to use parserOpts instead
danez
added
the
PR: Polish 💅
existentialism
force-pushed
the
babylon-parser-opts
branch
from
a8c9c3b
to
5652509
Compare
existentialism
force-pushed
the
babylon-parser-opts
branch
from
5652509
to
cbb25a7
Compare
| sourceType?: "module" | "script"; | ||
| filename?: string; | ||
| features?: Object; | ||
| plugins?: Object; |
There was a problem hiding this comment.
I guess plugins is an Array here - Array<Object>?
* Update babel parser options
lock
bot
added
the
outdated
Should we also support
strictMode(noted as TODO in https://github.com/babel/babylon/blob/master/src/options.js#L27)?