Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-doctor from babel-cli #4725

Merged
merged 2 commits into from Oct 14, 2016
Merged

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Oct 14, 2016

Q A
Bug fix? no
Breaking change? yes
New feature? no
Deprecations? yes
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #4678
License MIT
Doc PR

fixes #4678

This removes babel-doctor and its dependencies from babel-cli, but leaves the npm script and bin file, which I think is what was suggested in the issue. Let me know if I missed anything!

@codecov-io
Copy link

codecov-io commented Oct 14, 2016

Current coverage is 88.83% (diff: 100%)

Merging #4725 into master will not change coverage

@@             master      #4725   diff @@
==========================================
  Files           195        195          
  Lines         13795      13795          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3176       3176          
==========================================
  Hits          12255      12255          
  Misses         1540       1540          
  Partials          0          0          

Powered by Codecov. Last update 71790aa...0cfb249

@danez danez added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Oct 14, 2016
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Oct 14, 2016
@hzoo hzoo merged commit 50baac3 into babel:master Oct 14, 2016
@kaicataldo kaicataldo deleted the remove-babel-doctor branch October 14, 2016 19:13
chrisprice pushed a commit to chrisprice/babel that referenced this pull request Oct 18, 2016
* Remove babel-doctor from babel-cli

fixes babel#4678

* Throw when babel-doctor is used
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
* Remove babel-doctor from babel-cli

fixes babel#4678

* Throw when babel-doctor is used
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving babel-doctor to a separate package/removing
4 participants