Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path-exists with fs.existsSync #4731

Merged
merged 1 commit into from Oct 17, 2016
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 15, 2016

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

It's not deprecated anymore, see nodejs/node#8364

@codecov-io
Copy link

codecov-io commented Oct 15, 2016

Current coverage is 88.82% (diff: 100%)

Merging #4731 into master will decrease coverage by <.01%

@@             master      #4731   diff @@
==========================================
  Files           196        196          
  Lines         13840      13836     -4   
  Methods        1430       1430          
  Messages          0          0          
  Branches       3189       3189          
==========================================
- Hits          12294      12290     -4   
  Misses         1546       1546          
  Partials          0          0          

Powered by Codecov. Last update 05bdd48...59f2526

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 17, 2016
@danez
Copy link
Member

danez commented Oct 17, 2016

Awesome thanks. Could you please rebase?

@SimenB
Copy link
Contributor Author

SimenB commented Oct 17, 2016

@danez done

@hzoo hzoo merged commit 9c2794d into babel:master Oct 17, 2016
@SimenB SimenB deleted the drop-path-exists branch October 17, 2016 18:43
chrisprice pushed a commit to chrisprice/babel that referenced this pull request Oct 18, 2016
mstade added a commit to zambezi/babel that referenced this pull request Oct 28, 2016
* master: (38 commits)
  chore(package): update browserify to version 13.1.1 (babel#4762)
  Increase test coverage (babel#4742)
  Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758)
  Add variance node type and generate property variance annotations (babel#4697)
  Add make command to delete node_modules (babel#4748)
  fixes [skip ci]
  Support ObjectExpression in static path evaluation (babel#4746)
  Fix replacing for-of if inside label (babel#4736)
  Replace `path-exists` with `fs.existsSync` (babel#4731)
  Avoid unnecessary +0 in transform-es2015-parameters (babel#4738)
  [import()] Initial support for dynamic-import (babel#4699)
  Fix line endings on checkout
  Automatically generate missing expected.js fixtures (babel#4735)
  Fix few typos in issue/pr templates (babel#4739) [skip ci]
  contributing updates [skip ci]
  increase git depth [skip ci]
  Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734)
  Run ESLint on test files, and fix lint errors in test files (babel#4732)
  Add .gitattributes forcing LF line endings (babel#4730)
  Update tests for changed error messages in Babylon (babel#4727)
  ...
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants