New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change usage of "suite"/"test" in unit-tests to "describe"/"it" #4734
Conversation
Merge conflicts fixed |
Current coverage is 88.81% (diff: 100%)@@ master #4734 diff @@
==========================================
Files 195 195
Lines 13826 13826
Methods 1428 1428
Messages 0 0
Branches 3187 3187
==========================================
Hits 12280 12280
Misses 1546 1546
Partials 0 0
|
👍 |
@@ -17,7 +17,7 @@ suite("babel-code-frame", function () { | |||
].join("\n")); | |||
}); | |||
|
|||
test("optional column number", function () { | |||
it("optional column number", function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always thought that the function is called it
to help writing sentences that describe
the behavior. Like it('allows column numbers to be optional')
. I kinda always cringe when people use it
the test
way, but whatever :)
* master: (38 commits) chore(package): update browserify to version 13.1.1 (babel#4762) Increase test coverage (babel#4742) Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758) Add variance node type and generate property variance annotations (babel#4697) Add make command to delete node_modules (babel#4748) fixes [skip ci] Support ObjectExpression in static path evaluation (babel#4746) Fix replacing for-of if inside label (babel#4736) Replace `path-exists` with `fs.existsSync` (babel#4731) Avoid unnecessary +0 in transform-es2015-parameters (babel#4738) [import()] Initial support for dynamic-import (babel#4699) Fix line endings on checkout Automatically generate missing expected.js fixtures (babel#4735) Fix few typos in issue/pr templates (babel#4739) [skip ci] contributing updates [skip ci] increase git depth [skip ci] Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734) Run ESLint on test files, and fix lint errors in test files (babel#4732) Add .gitattributes forcing LF line endings (babel#4730) Update tests for changed error messages in Babylon (babel#4727) ...
Title should be self-explanatory.
Note that this will fail linting in CI until #4732 is merged intomaster
. This was a change suggested by @hzoo in #4733