Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line endings on checkout #4744

Merged
merged 1 commit into from Oct 17, 2016
Merged

Fix line endings on checkout #4744

merged 1 commit into from Oct 17, 2016

Conversation

nhajidin
Copy link
Contributor

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets
License MIT
Doc PR

When cloning the repository, the line endings were still CRLF.

I have core.autocrlf true in my global settings.

@codecov-io
Copy link

Current coverage is 88.82% (diff: 100%)

Merging #4744 into master will not change coverage

@@             master      #4744   diff @@
==========================================
  Files           195        195          
  Lines         13830      13830          
  Methods        1428       1428          
  Messages          0          0          
  Branches       3188       3188          
==========================================
  Hits          12284      12284          
  Misses         1546       1546          
  Partials          0          0          

Powered by Codecov. Last update b8eeddf...71e0e00

@motiz88
Copy link
Contributor

motiz88 commented Oct 17, 2016

Totally, thanks @nhajidin! My bad in fd218ab. Got to fix babel/babylon@4c396f4 too. :derp:
@danez

@motiz88 motiz88 merged commit 05bdd48 into babel:master Oct 17, 2016
@motiz88 motiz88 added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 17, 2016
motiz88 added a commit to babel/babylon that referenced this pull request Oct 17, 2016
hzoo pushed a commit to babel/babylon that referenced this pull request Oct 17, 2016
kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016
@nhajidin nhajidin deleted the fix-checkout branch November 14, 2016 18:02
JacopKane pushed a commit to JacopKane/babel that referenced this pull request Jan 11, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants