Handle remapping of JSXIdentifier to MemberExpression in CommonJS transform. Closes #3728

[DrewML]

Q	A
Bug fix?	yes
Breaking change?	no
New feature?	no
Deprecations?	no
Spec compliancy?	no
Tests added/pass?	yes
Fixed tickets	#3728, #3994
License	MIT
Doc PR	none

[codecov-io]

Current coverage is 89.38% (diff: 100%)

Merging #4763 into master will increase coverage by <.01%

@@             master      #4763   diff @@
==========================================
  Files           196        196          
  Lines         13887      13891     +4   
  Methods        1434       1434          
  Messages          0          0          
  Branches       3198       3199     +1   
==========================================
+ Hits          12412      12416     +4   
  Misses         1475       1475          
  Partials          0          0          

Powered by Codecov. Last update fd4667e...109c3b0

[danez]

Can you describe how this change works? By looking at the code I somehow can't figure out why the parentPath has to be JSXMemberExpression to make it's child be a JSXMemberExpression.

[DrewML]

@danez Thanks for making me think that through. Your instinct is totally right that the parent doesn't need to be a JSXMemberExpression (in fact, I'm probably missing some cases with that check).

I believe the check should just be path.isJSXIdentifier() && t.isMemberExpression(remap). Will push an update shortly.