fixes invalid line offsets in merged sourcemaps #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.32% (diff: 100%)
|
|
If someone can review Didn't know about https://sokra.github.io/source-map-visualization/#custom
check line 10/11 |
hzoo
added
the
PR: Bug Fix 🐛
|
@hzoo did you test it by uploading a file to this service? |
|
I pasted the test output but I didn't check the op
|
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourcemaps generated from multiple input files have invalid line offsets.
Problem is obvious when one considers
> "one line here\n".split("\n").length< 2Original tests were comparing results against invalid sourcemaps, which can be readily demonstrated by inspecting them for example by source-map-visualization. Also fixed.