Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-core's README #5014

Merged
merged 2 commits into from Dec 18, 2016
Merged

Update babel-core's README #5014

merged 2 commits into from Dec 18, 2016

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Dec 17, 2016

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets Fixes babel/website#1077
License MIT
Doc PR yes
Dependency Changes no

I also fixed broken links to options.

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nit, otherwise LGTM

@@ -9,7 +9,9 @@ import { transform } from 'babel-core';
import * as babel from 'babel-core';
```

## babel.transform(code: string, [options?](/docs/usage/api/#options): Object)
All transformation will use your local configuration files (.babelrc or in package.json). See [options](#options) to disable it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: transformations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@existentialism Thanks.

@xtuc xtuc requested a review from hzoo December 17, 2016 15:39
Copy link
Member

@DrewML DrewML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtuc xtuc merged commit 8edc1d9 into master Dec 18, 2016
@xtuc xtuc deleted the xtuc-patch-2 branch December 18, 2016 14:21
@existentialism existentialism added the PR: Docs 📝 A type of pull request used for our changelog categories label Jan 16, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API docs don't state whether .babelrc configs are respected
3 participants