Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary spaces around template element #5026

Merged

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Dec 21, 2016

Like was discussed in Slack chat with @ljharb and @hzoo spaces was added with no particular reason.

https://babeljs.slack.com/archives/discussion/p1481744017001806

I'm still not sure if everything here is correct (for example source maps)

Q A
Patch: Bug Fix? probably yes
Major: Breaking Change? no
Minor: New Feature? not sure
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets
License MIT
Doc PR
Dependency Changes

…ded with no particular reason.

https://babeljs.slack.com/archives/discussion/p1481744017001806

I'm still not sure if everything here is correct (for example source maps)
@codecov-io
Copy link

codecov-io commented Dec 21, 2016

Current coverage is 89.15% (diff: 100%)

Merging #5026 into master will decrease coverage by <.01%

@@             master      #5026   diff @@
==========================================
  Files           203        203          
  Lines          9823       9821     -2   
  Methods        1072       1072          
  Messages          0          0          
  Branches       2616       2614     -2   
==========================================
- Hits           8758       8756     -2   
  Misses         1065       1065          
  Partials          0          0          

Powered by Codecov. Last update ce0c620...07b5b0e

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hzoo hzoo added the PR: Polish 💅 A type of pull request used for our changelog categories label Dec 22, 2016
2. ${chino}
3. ${rize}
4. ${syaro}
5. ${chiya}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganfsmyth
Copy link
Member

Sounds good to me.

@loganfsmyth loganfsmyth merged commit f894619 into babel:master Dec 22, 2016
@chicoxyzzy chicoxyzzy deleted the dont_add_spaces_in_template_literals branch December 22, 2016 10:35
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants