Use native or lodash util module where full "lodash" is required #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.20% (diff: 86.36%)@@ master #5042 diff @@
==========================================
Files 203 203
Lines 9821 9819 -2
Methods 1071 1071
Messages 0 0
Branches 2615 2615
==========================================
- Hits 8761 8759 -2
Misses 1060 1060
Partials 0 0
|
Jessidhia
reviewed
Dec 26, 2016
| @@ -159,7 +162,7 @@ export default function ( | |||
| sourceMap: !!(task.sourceMappings || task.sourceMap), | |||
| }); | |||
|
|
|||
| _.extend(task.options, taskOpts); | |||
| extend(task.options, taskOpts); | |||
There was a problem hiding this comment.
Object.assign, or is it intended that taskOpts prototype keys are copied? How do you even get things in taskOpts' prototype since it comes from JSON?
There was a problem hiding this comment.
I don't know if it's intended for taskOpts prototype keys to be copied, so I'm doing the safe thing here and maintaining the exact same behavior. If this PR is merged, then I'll do another pass at removing some of these utils like in #5043.
| let cloneDeep = require("lodash/cloneDeep"); | ||
| let traverse = require("../lib").default; | ||
| let assert = require("assert"); | ||
| let parse = require("babylon").parse; |
There was a problem hiding this comment.
I also could've used arrow functions for the forEach's but I didn't because that's not what this PR is about.
existentialism
added
the
PR: Internal 🏠
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports all of the use sites of full
lodashto either using the piecemeal utility modules or their native equivalents.