Fix some README links #5045
Merged
Fix some README links #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Docs 📝
xtuc
approved these changes
Dec 26, 2016
| @@ -56,4 +56,4 @@ require("babel-core").transform("code", { | |||
|
|
|||
| ## Note | |||
|
|
|||
| This check will only validate consts. If you need it to compile down to `var` then you must also install and enable [`transform-es2015-block-scoping`](../babel-plugin-transform-es2015-block-scoping). | |||
There was a problem hiding this comment.
I think it was relative to be able to navigate in the documentation on Github.
There was a problem hiding this comment.
Yeah, we have to choose in cases like this whether it's more weird to:
- Jump to website when viewing on GitHub (or npm, etc)
- Jump to GitHub repo when viewing on website
There was a problem hiding this comment.
(Or attempt to do crazy relative path replacement on website :D)
There was a problem hiding this comment.
In this case it's the website for sure. It is also broken on npm.
| @@ -1,6 +1,6 @@ | |||
| # babel-plugin-transform-es2015-typeof-symbol | |||
|
|
|||
| > ES6 introduces a new native type called [symbols](http://babeljs.io/docs/learn-es6#symbols). This transformer wraps all `typeof` expressions with a method that replicates native behaviour. (ie. returning "symbol" for symbols) | |||
| > ES6 introduces a new native type called [symbols](https://babeljs.io/learn-es2015/#ecmascript-2015-features-symbols). This transformer wraps all `typeof` expressions with a method that replicates native behaviour. (ie. returning "symbol" for symbols) | |||
There was a problem hiding this comment.
Does your tests catch the nonexistent anchor?
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some broken links found by tests in babel/website#1102