Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more info to the Install section #5051

Merged
merged 2 commits into from Dec 29, 2016
Merged

Conversation

gitanupam
Copy link
Contributor

It was confusing to see the Install command for babel-present-react again when the earlier command to install CLI also included babel-preset-react. Hence the edit.

Q A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes #1, Fixes #2
License MIT
Doc PR
Dependency Changes

It was confusing to see the Install command for babel-present-react again when the earlier command to install CLI also included babel-preset-react. Hence the edit.
@codecov-io
Copy link

codecov-io commented Dec 28, 2016

Current coverage is 89.15% (diff: 100%)

No coverage report found for master at b1635f8.

Powered by Codecov. Last update b1635f8...438c872

@xtuc
Copy link
Member

xtuc commented Dec 28, 2016

Thanks for pointing out the issue.

I updated your branch. I moved the documentation from the website there, since it will be published on the website anyway.

It is now more clearer.

@xtuc xtuc added the PR: Docs 📝 A type of pull request used for our changelog categories label Dec 28, 2016
@existentialism
Copy link
Member

👍

@xtuc xtuc merged commit b443f3e into babel:master Dec 29, 2016
xtuc added a commit to babel/website that referenced this pull request Dec 29, 2016
* Adding more info to the Install section babel/babel#5051
yavorsky added a commit to yavorsky/babel.github.io that referenced this pull request Jan 19, 2017
commit 255d132
Author: Brian Ng <bng412@gmail.com>
Date:   Wed Jan 18 07:44:15 2017 -0600

    Move babel-register back under usage (babel#1143)

commit 0fa4028
Author: Renée Kooi <renee@kooi.me>
Date:   Tue Jan 17 20:58:06 2017 +0100

    Make the REPL work when cookies are blocked. (babel#1142)

    * Make the REPL work when cookies are blocked.

    If cookies are disabled, merely accessing `window.localStorage`
    throws an error. So the REPL would fail to load when creating its
    StorageService instance. This change moves the `localStorage`
    property access inside the try-catch blocks.

    * Log warning when localStorage is inaccessible.

commit 03885aa
Author: Brian Ng <bng412@gmail.com>
Date:   Mon Jan 16 01:27:52 2017 -0600

    Bump submodules to update docs (babel#1140)

commit a2a0e7a
Author: Mark Wubben <mark@novemberborn.net>
Date:   Mon Jan 16 03:49:49 2017 +0000

    Clarify how to disable babelrc lookup behavior (babel#1134)

commit e0bfd54
Author: David Buchan-Swanson <david.buchanswanson@gmail.com>
Date:   Mon Jan 16 13:49:32 2017 +1000

    New User: Tanda (babel#1139)

commit 713adc8
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Mon Jan 16 04:39:56 2017 +0100

    Update syntax-class-constructor-call.md (babel#1138)

commit 9983052
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Sat Jan 14 15:53:08 2017 +0100

    ES2015 transform consistent doc (babel#1135)

    * fix: es2015 transform consistent doc

    * chore: update babel gitsubmodule

commit 083fea9
Author: Ryan Ewing <ryan.ewing@concur.com>
Date:   Thu Jan 12 11:46:34 2017 -0800

    New User: Concur (babel#1133)

commit 729f56e
Author: Brian Ng <bng412@gmail.com>
Date:   Wed Jan 11 13:47:19 2017 -0600

    Refactor home page header (babel#1125)

commit 18e1a5c
Author: Benjamin Lupton <b@lupton.cc>
Date:   Thu Jan 12 03:22:35 2017 +0800

    New User: Bevry (babel#1129)

commit c619a23
Author: Benjamin Lupton <b@lupton.cc>
Date:   Thu Jan 12 03:17:16 2017 +0800

    Fix yarn link in 2016-12-07-the-state-of-babel.md (babel#1130)

commit 8014ad9
Author: Brian Ng <bng412@gmail.com>
Date:   Tue Jan 10 09:00:52 2017 -0600

    Add flex mixins directly instead

commit 559a906
Author: Brian Ng <bng412@gmail.com>
Date:   Tue Jan 10 08:43:11 2017 -0600

    Add flex-related mixins (babel#1128)

commit dc9a0c2
Merge: 0746fd8 77a85d3
Author: Henry Zhu <hi@henryzoo.com>
Date:   Sat Jan 7 11:41:51 2017 -0500

    Merge pull request babel#1104 from xtuc/feat-try-in-repl

    Try in REPL

commit 77a85d3
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Sat Jan 7 17:17:42 2017 +0100

    fix(copy): find element in parent

commit 2bf10d6
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Sat Jan 7 16:52:37 2017 +0100

    fix: style minor change

commit 0746fd8
Author: Brian Ng <bng412@gmail.com>
Date:   Sat Jan 7 09:46:31 2017 -0600

    Replace github, slack and twitter links with icons (babel#1124)

commit 6948e0d
Author: Stepan Anchugov <kixxx1@gmail.com>
Date:   Sat Jan 7 20:46:17 2017 +0500

    Reword "serializable JSON" (babel#1123)

    "Serializable JSON" doesn't make much sense to me: JSON is a serialized format, while this sentence sounded like you could serialize JSON further. Perhaps, this wording would be better?

commit 1f02773
Author: Brian Ng <bng412@gmail.com>
Date:   Thu Jan 5 21:53:02 2017 -0600

    tweak design

commit 0d9627c
Author: Ritesh Manchanda <me@ritesh.it>
Date:   Tue Jan 3 10:30:56 2017 -0500

    New User: Namely (babel#1122)

commit 599cf88
Author: Daniel Lo Nigro <daniel@dan.cx>
Date:   Tue Jan 3 12:51:58 2017 +1100

    Rename "Discourse" link to "Forum" (babel#1121)

    People don't really care that Babel is using Discourse for the forum, just that it actually **is** a forum. Discourse is just an implementation detail. You say "send me an email" not "send me a Gmail", and "give me a phone call" not "contact me via the AT&T network", so this link should read "Forum" or "Discuss" rather than "Discourse".

    @hzoo

    People that don't have experience with Discourse would be confused by the current link.

commit 9b3fba0
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Sun Jan 1 15:01:19 2017 +0100

    chore: update Babel submodule

    * docs: [skip ci] incorrect snippet language (#5059)

commit 3579cf0
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Sun Jan 1 14:52:07 2017 +0100

    Fix trailing slash in core-packages (babel#1119)

    * Revert "Fix 404 for babel-register menu item (babel#1116)"

    This reverts commit 4a7a990.

    * fix: add trailing slash in core-pckages links

commit 6ca9845
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Sat Dec 31 18:43:41 2016 +0100

    Add Babylon documentation (babel#1107)

    * feat: add babylon submodule

    * feat: add package info

    * feat: add page

    * fix: update title and description

commit 4a7a990
Author: Felix Kling <felix.kling@gmx.net>
Date:   Sat Dec 31 09:43:00 2016 -0800

    Fix 404 for babel-register menu item (babel#1116)

    It appears that URLs are treated differently if they contain a trailing slash. `/docs/core-packages/babel-register` works, `/docs/core-packages/babel-register/` results in a 404.

commit 88477d5
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Sat Dec 31 18:42:03 2016 +0100

    Some updates in the main page (babel#1108)

    * fix: remove big buttons

    * fix: inscrease space between sections

commit ca7a8d2
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Sat Dec 31 15:58:42 2016 +0100

    fix: add missing description in syntax flow and jsx (babel#1115)

commit 220251d
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Sat Dec 31 14:16:58 2016 +0100

    feat: use a play icon for try in repl

commit 37ef4b0
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Thu Dec 29 08:31:05 2016 +0100

    chore: force update submodules

    * Adding more info to the Install section babel/babel#5051

commit a845ff7
Author: Sven SAULEAU <xtuc@users.noreply.github.com>
Date:   Thu Dec 29 08:28:42 2016 +0100

    Update preset-react (babel#1110)

commit 7b6348f
Author: Brian Ng <bng412@gmail.com>
Date:   Sun Dec 25 21:23:12 2016 -0600

    Remove duplicate babel-register page (babel#1103)

commit 4526dbc
Author: Sven SAULEAU <sven.sauleau@xtuc.fr>
Date:   Sat Dec 24 12:09:15 2016 +0100

    feat: try in REPL
@gitanupam gitanupam deleted the patch-1 branch February 14, 2017 10:13
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants