Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize removal-hooks for ArrowFunctions #5076

Merged
merged 1 commit into from Jan 9, 2017
Merged

Optimize removal-hooks for ArrowFunctions #5076

merged 1 commit into from Jan 9, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jan 8, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

When the body of an ArrowFunctionExpression is removed generate () => {} instead of () => void 0

@danez danez added PR: Polish 💅 A type of pull request used for our changelog categories area: perf labels Jan 8, 2017
@codecov-io
Copy link

codecov-io commented Jan 8, 2017

Current coverage is 89.20% (diff: 100%)

Merging #5076 into master will increase coverage by 0.04%

@@             master      #5076   diff @@
==========================================
  Files           203        203          
  Lines          9821       9817     -4   
  Methods        1072       1071     -1   
  Messages          0          0          
  Branches       2614       2613     -1   
==========================================
+ Hits           8756       8757     +1   
+ Misses         1065       1060     -5   
  Partials          0          0          

Powered by Codecov. Last update d1cd179...0cca93f

@loganfsmyth
Copy link
Member

Looks good to me. :shipit:

@hzoo
Copy link
Member

hzoo commented Jan 9, 2017

Cool and thanks for the test setup!

@hzoo hzoo merged commit dc61712 into master Jan 9, 2017
@hzoo hzoo deleted the danez-patch-1 branch January 9, 2017 22:57
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants