Static function call result comment does not match variable content [skip ci] #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static staticProperty, defined in line 18, value is 'babeliscool' but comment on line 33 the given sample output is 'babelIsCool'. this commit fixes this inconsistency
|
Looks good. |
Current coverage is 89.15% (diff: 100%)@@ master #5077 diff @@
==========================================
Files 203 203
Lines 9821 9821
Methods 1072 1072
Messages 0 0
Branches 2614 2614
==========================================
Hits 8756 8756
Misses 1065 1065
Partials 0 0
|
|
I see, thanks for contributing @kasn! |
hzoo
added
the
PR: Docs 📝
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
…abel#5077) static staticProperty, defined in line 18, value is 'babeliscool' but comment on line 33 the given sample output is 'babelIsCool'. this commit fixes this inconsistency
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| Patch: Bug Fix? | no
| Major: Breaking Change? | no
| Minor: New Feature? | no
| Deprecations? | no
| Spec Compliancy? | no
| Tests Added/Pass? | no
| Fixed Tickets |
| License | MIT
| Doc PR | yes
| Dependency Changes | no
static staticProperty, defined in line 18, value is 'babeliscool' but comment on line 33 the given sample output is 'babelIsCool'.
this commit fixes this inconsistency