Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-code-frame: Upgrade to js-tokens@3 #5094

Merged
merged 1 commit into from Jan 13, 2017
Merged

Conversation

lydell
Copy link
Contributor

@lydell lydell commented Jan 11, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no/yes
Fixed Tickets none
License MIT
Doc PR no
Dependency Changes js-tokens@2 → js-tokens@3

js-tokens@3 version brings a big performance boost.

That version brings a big performance boost.
@codecov-io
Copy link

codecov-io commented Jan 11, 2017

Current coverage is 89.20% (diff: 100%)

Merging #5094 into master will not change coverage

@@             master      #5094   diff @@
==========================================
  Files           203        203          
  Lines          9817       9817          
  Methods        1071       1071          
  Messages          0          0          
  Branches       2613       2613          
==========================================
  Hits           8757       8757          
  Misses         1060       1060          
  Partials          0          0          

Powered by Codecov. Last update 39d1867...77c387b

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 12, 2017
Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,4 +1,4 @@
import jsTokens from "js-tokens";
import jsTokens, {matchToToken} from "js-tokens";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought we had an eslint rule for spacing?

(don't have to change)

@hzoo hzoo merged commit d2113d4 into babel:master Jan 13, 2017
@lydell lydell deleted the js-tokens branch January 13, 2017 17:13
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
That version brings a big performance boost.
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants