Validate importKind and ensure code generation exists. #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.20% (diff: 100%)@@ master #5110 diff @@
==========================================
Files 203 203
Lines 9819 9822 +3
Methods 1071 1071
Messages 0 0
Branches 2615 2616 +1
==========================================
+ Hits 8759 8762 +3
Misses 1060 1060
Partials 0 0
|
danez
approved these changes
Jan 14, 2017
| }, | ||
| importKind: { | ||
| // Handle Flowtype's extension "import {typeof foo} from" | ||
| validate: assertOneOf(null, "type", "typeof") |
There was a problem hiding this comment.
It would be nice if we could do extensions to nodes in corresponding files. So that flow.js could extend ImportSpecifier. But for now there is no other way afaics.
hzoo
added
the
PR: New Feature 🚀
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements two small things that were not included in #5035