Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaicataldo enable prefer const #5113

Merged
merged 3 commits into from Jan 14, 2017
Merged

Kaicataldo enable prefer const #5113

merged 3 commits into from Jan 14, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jan 14, 2017

No description provided.

@mention-bot
Copy link

Unable to parse mention-bot custom configuration file due to a syntax error.
Please check the potential root causes below:

  1. Having comments
  2. Invalid JSON type
  3. Having extra "," in the last JSON attribute

@mention-bot
Copy link

@hzoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kittens, @amasad and @loganfsmyth to be potential reviewers.

@hzoo
Copy link
Member Author

hzoo commented Jan 14, 2017

That sucks.. fixed the comments ^ (sorry all)

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 14, 2017
@hzoo hzoo merged commit 672adba into master Jan 14, 2017
@hzoo hzoo deleted the kaicataldo-enable-prefer-const branch January 14, 2017 17:47
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants