Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor packages to use ES modules instead of CJS #5138

Merged
merged 1 commit into from Jan 16, 2017

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Jan 16, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets
License MIT
Doc PR
Dependency Changes

This was a part of #5131 originally but as was suggested in #5131 (comment) by @hzoo this is not a breaking change so these may land to Babel 6

@mention-bot
Copy link

@chicoxyzzy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @DrewML and @davidaurelio to be potential reviewers.

@chicoxyzzy chicoxyzzy force-pushed the refactor_packages_to_es_modules branch from 91cc9bd to ff71271 Compare January 16, 2017 14:33
@codecov-io
Copy link

codecov-io commented Jan 16, 2017

Current coverage is 89.21% (diff: 100%)

No coverage report found for master at b315fc6.

Powered by Codecov. Last update b315fc6...ff71271

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Jan 16, 2017

This branch has exactly same changes as in #5131 except:

  • package.json - plugin remove
  • packages/babel-core/register.js - default property should be added there (or ES import + export used)
  • scripts/add-module-exports.js - file remove

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 16, 2017
@hzoo hzoo merged commit 292c3ca into babel:master Jan 16, 2017
@chicoxyzzy chicoxyzzy deleted the refactor_packages_to_es_modules branch January 16, 2017 16:29
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants