Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency status extension. #5144

Merged
merged 1 commit into from Jan 16, 2017
Merged

Fix dependency status extension. #5144

merged 1 commit into from Jan 16, 2017

Conversation

yavorsky
Copy link
Member

@yavorsky yavorsky commented Jan 16, 2017 •
edited

Q A
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Deprecations? n
Spec Compliancy? n
Tests Added/Pass? n
Fixed Tickets n
License MIT
Doc PR y
Dependency Changes n

Oops, sorry for broken dependency status svg url in the previous PR.
P.S. I promise to make a really helpful PR in the future 馃槃

@yavorsky yavorsky changed the title [skip ci] Fix dependency status extension. Fix dependency status extension. Jan 16, 2017
@existentialism existentialism added the PR: Docs 馃摑 A type of pull request used for our changelog categories label Jan 16, 2017
@existentialism existentialism merged commit 2457c8e into babel:master Jan 16, 2017
@hzoo
Copy link
Member

hzoo commented Jan 17, 2017

Honestly we should just remove es2015,16,17 from the readme haha since there's not a good reason to recommend that over latest/env

@yavorsky
Copy link
Member Author

yavorsky commented Jan 17, 2017 •
edited

馃憤
Also, after babel/babel-preset-env#114 merge we could add engines option to package.json and replace es2015 with env. I believe that everyone will do so 馃槍 then.

panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@yavorsky @panagosg7
[skip ci] Fix dependency status extension. (babel#5144)
7b3a4f4
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 馃摑 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yavorsky @hzoo @existentialism