Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump home-or-tmp for babel-register. #5189

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Bump home-or-tmp for babel-register. #5189

merged 1 commit into from
Jan 24, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Q A
Patch: Bug Fix? No
Major: Breaking Change? No (for babel@7.0.0)
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? No
Fixed Tickets N/A
License MIT
Doc PR No
Dependency Changes Yes

Bump home-or-tmp from ^2.0.0 to ^3.0.0. 3.0.0 drops the ponyfills for os.homedir and os.tmpdir.

@mention-bot
Copy link

@wtgtybhertgeghgtwtg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @zloirock and @danez to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Jan 21, 2017

Current coverage is 89.61% (diff: 100%)

Merging #5189 into 7.0 will not change coverage

@@                7.0      #5189   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 728072f...155f03c

@hzoo hzoo added this to the Babel 7 milestone Jan 21, 2017
@existentialism existentialism added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Internal 🏠 A type of pull request used for our changelog categories labels Jan 23, 2017
@hzoo
Copy link
Member

hzoo commented Jan 23, 2017

Since it's just os.homedir() || os.tmpdir(); I kinda wanted us to just use https://github.com/avajs/find-cache-dir instead? We did this for babel-loader already with https://github.com/babel/babel-loader/blob/e9e37029e0c5905d8846f69d9a0c348f3d49fe50/src/fs-cache.js#L164-L174

const FILENAME = process.env.BABEL_CACHE_PATH || path.join(homeOrTmp, ".babel.json");

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

Understood.

@hzoo
Copy link
Member

hzoo commented Jan 23, 2017

I think we can still land it - It depends if everyone else agrees we should move the cache directory to node_modules or not - have any thoughts on that?

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

wtgtybhertgeghgtwtg commented Jan 23, 2017

Sounds good. I'll reopen while you decide that. I would like to have find-cache-dir and pkg-dir bump the minimum supported version to node@4.0.0 so it can bump the find-up dependency, but that's besides the point.

@hzoo
Copy link
Member

hzoo commented Jan 24, 2017

I think we can make #5198 and still fallback to home-or-tmp?

@hzoo hzoo merged commit 398b032 into babel:7.0 Jan 24, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the bump-home-or-tmp branch January 24, 2017 10:58
@hzoo
Copy link
Member

hzoo commented Jan 26, 2017

And if you'd like to do an issue to investigate slimming deps feel free to do so. I'm tried before but didn't find anything other than #5118 which would be in 7.0

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

babel is pretty small and close-knit, so there isn't really much to be done in that area outside of dropping ponyfills (the most obvious already done with #5179) and bumping stuff (i.e. bumping detect-indent from ^4.0.0 to ^5.0.0 for babel-generator would remove repeating, is-finite, and number-is-nan) for babel@7.0.0.

@hzoo
Copy link
Member

hzoo commented Jan 26, 2017

bumping stuff (i.e. bumping detect-indent from ^4.0.0 to ^5.0.0 for babel-generator would remove repeating, is-finite, and number-is-nan) for babel@7.0.0.

Ok yeah if you would like to make PRs (or an issue we can make beginner-friendly) for those in 7.0 would be appreciated!

@hzoo
Copy link
Member

hzoo commented Jan 26, 2017

Actually I don't see any of those other deps (must of been removed already) https://github.com/babel/babel/blob/7.0/packages/babel-generator/package.json

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

repeating is a dependency of detect-indent@4.0.0, but not detect-indent@5.0.0, which uses ' '.repeat. repeating depends upon is-finite, which depends upon number-is-nan.
PR: #5226

hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 7.0: (37 commits)
  resolved conflicts
  [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319)
  [7.0] Replacing current decorators with decorators-legacy (babel#5290)
  Add Node 7 to CI (babel#5165)
  [7.0] remove standalone babel package (babel#5293)
  .gitignore for test [skip ci]
  update yarn
  use lerna@2-beta.37 (babel#5254)
  [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263)
  [7.0] Remove quotes option (babel#5154)
  [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231)
  Remove babel-runtime from packages' dependencies (babel#5218)
  Bump `detect-indent`. (babel#5226)
  [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225)
  [7.0] Use lerna's --independent mode + changes (fixes babel#5221)
  [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189)
  [7.0] Added yarn.lock (babel#5175)
  [7.0] Remove old babel-runtime code (babel#5187)
  [7.0] Drop support for Node 5 (babel#5186)
  Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179)
  ...
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants