[7.0] Run Babel's unittests in a custom sandbox (take 2). #5263
Conversation
|
@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @zertosh and @motiz88 to be potential reviewers. |
hzoo
added
the
PR: Internal 🏠
Codecov Report@@ Coverage Diff @@
## 7.0 #5263 +/- ##
==========================================
+ Coverage 89.61% 89.63% +0.02%
==========================================
Files 200 200
Lines 9752 9772 +20
Branches 2596 2601 +5
==========================================
+ Hits 8739 8759 +20
Misses 1013 1013
Continue to review full report at Codecov.
|
|
Doesn't look slower at all without node 0.10/0.12 Can you do that simple test that adding something to the global scope in the source doesn't affect the test? (so we can prevent the error that caused us to want this PR in the first place?) basically that we used a polyfill when it wouldn't be supported otherwise |
loganfsmyth
force-pushed
the
sandbox-tests
branch
from
b888759
to
f4d7eb3
Compare
|
@hzoo Added a test, is that what you had in mind? It just tests that things run in independent environments, since it seems like explicitly testing for something standard might be tough to get consistent across node versions? |
* 7.0: (37 commits) resolved conflicts [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319) [7.0] Replacing current decorators with decorators-legacy (babel#5290) Add Node 7 to CI (babel#5165) [7.0] remove standalone babel package (babel#5293) .gitignore for test [skip ci] update yarn use lerna@2-beta.37 (babel#5254) [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263) [7.0] Remove quotes option (babel#5154) [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231) Remove babel-runtime from packages' dependencies (babel#5218) Bump `detect-indent`. (babel#5226) [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225) [7.0] Use lerna's --independent mode + changes (fixes babel#5221) [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189) [7.0] Added yarn.lock (babel#5175) [7.0] Remove old babel-runtime code (babel#5187) [7.0] Drop support for Node 5 (babel#5186) Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179) ...
lock
bot
added
the
outdated
Take 2 for #5135. I simplified the code a little, and now I'm submitting it to 7.0 branch since is was too difficult to get this to work Babel 6 for both modern Node 6 and 0.10.