Fix for-await printing #5322
Merged
Fix for-await printing #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first for-await was correctly printed all subsequent for-await statements where printed as for-of as the variable op was changed inside the buildForXStatement
danez
added
the
PR: Bug Fix 🐛
|
@danez, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @erikdesjardins to be potential reviewers. |
hzoo
approved these changes
Feb 15, 2017
hzoo
reviewed
Feb 15, 2017
| @@ -18,11 +18,11 @@ async function a() { | |||
| for ({ a } in {}) {} | |||
| for ({ a } of []) {} | |||
| async function a() { | |||
| for ({ a } of []) {} | |||
| for await ({ a } of []) {} | |||
There was a problem hiding this comment.
Sad that I didn't catch this before
|
|
Codecov Report
@@ Coverage Diff @@
## master #5322 +/- ##
==========================================
- Coverage 89.44% 89.44% -0.01%
==========================================
Files 204 204
Lines 9950 9949 -1
Branches 2688 2689 +1
==========================================
- Hits 8900 8899 -1
Misses 1050 1050
Continue to review full report at Codecov.
|
Merged
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
Only the first for-await was correctly printed all subsequent for-await statements where printed as for-of as the variable op was changed inside the buildForXStatement
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first for-await was correctly re-printed as for-await all subsequent for-await statements
where printed as for-of as the variable op was changed inside the buildForXStatement during the first run.