Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with respect to coverage check [skip ci] #5329

Merged
merged 1 commit into from Feb 17, 2017

Conversation

zjmiller
Copy link
Contributor

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets none
License MIT
Doc PR yes
Dependency Changes no

CONTRIBUTING.md referred to an old and no longer used way to run the coverage check. I updated it to refer to ./scripts/test-cov.sh directly.

@hzoo hzoo added the PR: Docs 📝 A type of pull request used for our changelog categories label Feb 17, 2017
@hzoo hzoo merged commit d55a775 into babel:master Feb 17, 2017
@hzoo
Copy link
Member

hzoo commented Feb 17, 2017

👍 awesome

@xtuc
Copy link
Member

xtuc commented Feb 17, 2017

Thanks for your PR 👍

Do we want to publish the contributing document on the website?

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants