Shorthand properties examples #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example output did not match the actual output
xtuc
added
the
PR: Docs 📝
| @@ -30,7 +30,7 @@ var cat = { | |||
|
|
|||
| ```js | |||
| var cat = { | |||
| getName: function () { | |||
| getName: function getName() { | |||
There was a problem hiding this comment.
Actually, the current example is correct... the REPL currently only lets you select presets, and not individual plugins... the function is getting its name from transform-es2015-function-name.
(p.s. we'd love for someone to help us augment the REPL to fix this!)
There was a problem hiding this comment.
When you run Try on the plugin's page on the website. The preset es2015 is enable by default.
There was a problem hiding this comment.
I know but it seems weird to say that the output for this specific transform is what the preset outputs and not the plugin?
There was a problem hiding this comment.
I agree. I'll limit the change to just the missing space on line 16.
The function name comes from the function name transform, not the shorthand property transform.
|
Thanks @bhoule! |
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shorthand properties example output did not match the actual output