Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov partial coverage #5336

Merged
merged 1 commit into from Feb 22, 2017
Merged

Enable codecov partial coverage #5336

merged 1 commit into from Feb 22, 2017

Conversation

danez
Copy link
Member

@danez danez commented Feb 18, 2017

Q A
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Deprecations?
Spec Compliancy? n
Tests Added/Pass? n
Fixed Tickets
License MIT
Doc PR
Dependency Changes

We already upload json format to codecov (which supports partial coverage) and this enables partial support in codecov.

Coverage will most likely drop.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 18, 2017
@codecov
Copy link

codecov bot commented Feb 18, 2017

Codecov Report

Merging #5336 into master will decrease coverage by -5.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5336      +/-   ##
==========================================
- Coverage   89.44%   84.36%   -5.08%     
==========================================
  Files         204      204              
  Lines        9949     9616     -333     
  Branches     2689     2688       -1     
==========================================
- Hits         8899     8113     -786     
+ Misses       1050     1014      -36     
- Partials        0      489     +489
Impacted Files Coverage Δ
packages/babel-core/src/helpers/merge.js 75% <ø> (-25%)
packages/babel-messages/src/index.js 61.53% <ø> (-24.18%)
...ckages/babel-plugin-transform-runtime/src/index.js 75.4% <ø> (-21.32%)
packages/babel-helper-call-delegate/src/index.js 68% <ø> (-20%)
...kages/babel-traverse/src/path/lib/removal-hooks.js 59.25% <ø> (-18.52%)
...es/babel-plugin-transform-strict-mode/src/index.js 83.33% <ø> (-16.67%)
...l-plugin-transform-es2015-modules-umd/src/index.js 82.14% <ø> (-16.08%)
packages/babel-register/src/node.js 76.56% <ø> (-15.63%)
packages/babel-core/src/api/node.js 66.66% <ø> (-15.16%)
...bel-plugin-transform-react-jsx-source/src/index.js 77.77% <ø> (-15.08%)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dd2b1...89e947c. Read the comment docs.

@hzoo
Copy link
Member

hzoo commented Feb 22, 2017

Sounds like a good idea? Did we do this on babylon already?

@hzoo hzoo merged commit be293bd into master Feb 22, 2017
@hzoo hzoo deleted the codecov-partial branch February 25, 2017 17:25
@danez
Copy link
Member Author

danez commented Feb 27, 2017

Yes babylon has this already

existentialism pushed a commit that referenced this pull request May 19, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants