Remove redundant NODE_ENV=test in Makefile #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NODE_ENV=test` is exported by default. Therefore, targets that set `NODE_ENV` to `test` are cleaned up.
|
@aaronang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @kaicataldo and @danez to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5350 +/- ##
=========================================
Coverage ? 89.44%
=========================================
Files ? 204
Lines ? 9949
Branches ? 2689
=========================================
Hits ? 8899
Misses ? 1050
Partials ? 0Continue to review full report at Codecov.
|
hzoo
reviewed
Feb 21, 2017
| make test-only | ||
|
|
||
| test-ci-coverage: | ||
| NODE_ENV=test BABEL_ENV=cov make bootstrap |
There was a problem hiding this comment.
Yeah that is odd, since BABEL_ENV is set here.
const envKey = process.env.BABEL_ENV || process.env.NODE_ENV || "development"; in our code currently
hzoo
approved these changes
Feb 21, 2017
hzoo
added
the
PR: Internal 🏠
existentialism
approved these changes
Feb 22, 2017
|
Good catch! |
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
`NODE_ENV=test` is exported by default. Therefore, targets that set `NODE_ENV` to `test` are cleaned up.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE_ENV=testis exported by default inMakefile. Therefore, targets that setNODE_ENVtotestare cleaned up.