Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport noInterop flag for modules to 6.x. #5427

Merged
merged 2 commits into from Mar 7, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 7, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? yes
Deprecations? no
Spec Compliancy? yes
Tests Added/Pass? yes
Fixed Tickets Fixes #4073, Closes #4071
License MIT
Doc PR no
Dependency Changes no

Backport changes from #5422 into master (for release within 6.x).

  • Add noInterop option to babel-plugin-transform-es2015-modules-commonjs.
  • Document strict option to es2015-modules-commonjs
  • Document new noInterop option to es2015-modules-commonjs
  • Reference es2015-modules-commonjs options from es2015-modules-amd

…onjs`.

The intent of this option is to toggle module interop behavior. When `true`
no `interopRequireXXX` helper invocations will be emitted.

(cherry picked from commit 0d1edb9)
@mention-bot
Copy link

@rwjblue, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @loganfsmyth and @benjamn to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2127df0). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5427   +/-   ##
=========================================
  Coverage          ?   84.44%           
=========================================
  Files             ?      204           
  Lines             ?     9596           
  Branches          ?     2694           
=========================================
  Hits              ?     8103           
  Misses            ?     1006           
  Partials          ?      487
Impacted Files Coverage Δ
...gin-transform-es2015-modules-commonjs/src/index.js 94.49% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2127df0...2909959. Read the comment docs.

@loganfsmyth loganfsmyth merged commit ea787a1 into babel:master Mar 7, 2017
@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Mar 13, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
4 participants