Fixed broken links in README.md [skip-ci] #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sethbergman
commented
Mar 12, 2017
sethbergman
commented
- plugins changed to plugins
- presets changed to presets
| Q | A |
|---|---|
| Patch: Bug Fix? | no |
| Major: Breaking Change? | no |
| Minor: New Feature? | no |
| Deprecations? | no |
| Spec Compliancy? | no |
| Tests Added/Pass? | no |
| Fixed Tickets | no |
| License | MIT |
| Doc PR | yes |
| Dependency Changes | no |
- [plugins](https://github.com/babel/babel/blob/master/docs/plugins) => [plugins](https://babeljs.io/docs/plugins/) - [presets](https://github.com/babel/babel/blob/master/docs/plugins/#presets) => [presets](https://babeljs.io/docs/plugins/preset-latest/)
|
@sethbergman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xtuc, @existentialism and @novemberborn to be potential reviewers. |
aaronang
suggested changes
Mar 12, 2017
There was a problem hiding this comment.
@sethbergman Thank you for your contribution 🎉
For future documentation changes, please use [skip ci] in your commit message to prevent Travis from building. Not a big problem though if you don't; I forget it quite often too 😅
packages/babel-core/README.md
Outdated
| | `plugins` | `[]` | List of [plugins](/docs/plugins/) to load and use. | | ||
| | `presets` | `[]` | List of [presets](/docs/plugins/#presets) (a set of plugins) to load and use. | | ||
| | `plugins` | `[]` | List of [plugins](https://babeljs.io/docs/plugins/) to load and use. | | ||
| | `presets` | `[]` | List of [presets](https://babeljs.io/docs/plugins/preset-latest/) (a set of plugins) to load and use. | |
There was a problem hiding this comment.
@sethbergman I think this one is incorrect. Could you fix this to: http://babeljs.io/docs/plugins/#presets? Thanks 😬
Changed to: ``` [presets](https://babeljs.io/docs/plugins/#presets) ```
aaronang
approved these changes
Mar 12, 2017
hzoo
added
the
PR: Docs 📝
hulkish
added a commit
to hulkish/babel
that referenced
this pull request
May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits) Increase the code coverage for traverse evaluation (babel#5363) Improve options documentation for `babel-plugin-transform-runtime` babel#5401 [doc] Fix: comments in usage w/ options babel#5400 document cache option for babel-register babel#5440 Update coffescript/register reference link address babel#5475 Update babel-generator's README babel#5517 Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573 Remove incorrect docs. babel#5580 Update transform-es2015-modules-commonjs doc babel#5588 Fix replacing function declaration in export default (fixes babel#4468) (babel#5456) Fix a typo: occurences -> occurrences (babel#5575) Fix changelog [skip ci] Treat "await" as an invalid identifier (babel#4954) Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486) docs: [skip ci] update documentation v6.24.0 changelog for 6.24.0 [skip ci] (babel#5452) Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453) Use absolute paths in Babel's CONTRIBUTING.md (babel#5431) Fixed broken links in README.md [skip ci] (babel#5449) ...
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
* Fixed broken links in README.md - [plugins](https://github.com/babel/babel/blob/master/docs/plugins) => [plugins](https://babeljs.io/docs/plugins/) - [presets](https://github.com/babel/babel/blob/master/docs/plugins/#presets) => [presets](https://babeljs.io/docs/plugins/preset-latest/) * Corrected the presets link [skip-ci] Changed to: ``` [presets](https://babeljs.io/docs/plugins/#presets) ```
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.