New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitignore package-lock #5918
Gitignore package-lock #5918
Conversation
@sarupbanskota, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @Kovensky and @loganfsmyth to be potential reviewers. |
Yes I agree, we should ignore it. I'm just wondering NPM5 is not covereded by our devEngines restrictions https://github.com/babel/babel/blob/7.0/package.json#L55. |
I don't find the issue anymore but I know we wanted to assert the developer's environment (Node version and NPM version) but that's not the case atm. Would be nice if you have the time to bump our devEngines configuration. It should at least match our test infrastructure versions. |
We would want to keep it in source just like yarn.lock - the issue is that yarn doesn't handle npm 5 atm |
Yes but we maybe want a Yarn only workflow? Because otherwise we need to update both lock files. |
exactly @xtuc, that is what I thought, that we wanna stick with just yarn. (not that I'm excited about it thanks to npm5 😉) I'll bump the devEngines config tonight and update this PR |
Bumped the 💭 This was the first time I saw a Lmk if you folks think I should make more changes! |
Every time I run
make bootstrap
, there are severalpackage-lock.json
files created in the repo. I wasn't exactly sure if we wanna check them in, so instead of raising an issue asking what everybody thinks, I decided to make a PR anyway. Feel free to close it if it isn't necessary