Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore package-lock #5918

Merged
merged 2 commits into from Jul 10, 2017
Merged

Gitignore package-lock #5918

merged 2 commits into from Jul 10, 2017

Conversation

sarupbanskota
Copy link
Contributor

Every time I run make bootstrap, there are several package-lock.json files created in the repo. I wasn't exactly sure if we wanna check them in, so instead of raising an issue asking what everybody thinks, I decided to make a PR anyway. Feel free to close it if it isn't necessary

@mention-bot
Copy link

@sarupbanskota, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @Kovensky and @loganfsmyth to be potential reviewers.

@xtuc
Copy link
Member

xtuc commented Jul 5, 2017

Yes I agree, we should ignore it. I'm just wondering NPM5 is not covereded by our devEngines restrictions https://github.com/babel/babel/blob/7.0/package.json#L55.

@sarupbanskota
Copy link
Contributor Author

@xtuc hmm fair enough, but considering we wanted to have Node 8 at least on Travis via #5807, I'm assuming we'll wanna also cover node 8 and npm 5? (happy to make the change)

@xtuc
Copy link
Member

xtuc commented Jul 5, 2017

I don't find the issue anymore but I know we wanted to assert the developer's environment (Node version and NPM version) but that's not the case atm.

Would be nice if you have the time to bump our devEngines configuration. It should at least match our test infrastructure versions.

@hzoo
Copy link
Member

hzoo commented Jul 5, 2017

We would want to keep it in source just like yarn.lock - the issue is that yarn doesn't handle npm 5 atm

@xtuc
Copy link
Member

xtuc commented Jul 5, 2017

Yes but we maybe want a Yarn only workflow? Because otherwise we need to update both lock files.

@sarupbanskota
Copy link
Contributor Author

exactly @xtuc, that is what I thought, that we wanna stick with just yarn. (not that I'm excited about it thanks to npm5 😉)

I'll bump the devEngines config tonight and update this PR

@sarupbanskota
Copy link
Contributor Author

Bumped the engines (💭) to include node 8 and npm5.

💭 This was the first time I saw a devEngines option so I was googling it, but couldn't find much information on what package it's made available through. Reading npm/npm#9765 (comment), I thought it would be gbjs-scripts but that's not in our list. So maybe relevant code was copied, but then #5312 the original PR that introduced it doesn't have any extra code. Reading https://docs.npmjs.com/files/package.json#engines it seemed like engines does what we want so I stuck with just that, but couldn't find code that could be removed because of this change.

Lmk if you folks think I should make more changes!

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 10, 2017
@existentialism existentialism merged commit a7a9e7a into babel:7.0 Jul 10, 2017
@sarupbanskota sarupbanskota deleted the housekeeping/ignore-npm-lock branch July 17, 2017 04:30
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants