Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Smart Pipeline proposal in @babel/parser #8289

Merged
merged 27 commits into from Dec 3, 2018

Commits on Jul 10, 2018

  1. Copy the full SHA
    fbf62b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Reverse yoda conditions

    If "smart" proposal is, we'll no longer say.
    mAAdhaTTah committed Jul 13, 2018
    Copy the full SHA
    ef0f723 View commit details
    Browse the repository at this point in the history
  2. Inline function checkSmartPipelineHeadEarlyErrors

    It's only used once.
    mAAdhaTTah committed Jul 13, 2018
    Copy the full SHA
    b50fdc1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0084570 View commit details
    Browse the repository at this point in the history
  4. Delete commented code

    mAAdhaTTah committed Jul 13, 2018
    Copy the full SHA
    7188820 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    cc52694 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    e91a02c View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    b847d40 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    7931f4c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2018

  1. Copy the full SHA
    6e41edb View commit details
    Browse the repository at this point in the history
  2. Reuse hash token instead of new primaryTopicToken

    Set whether we're in a pipeline in order to determine how to parse the
    hash. The error message changes as a result, since the `hash` never
    enters the block.
    mAAdhaTTah committed Jul 22, 2018
    Copy the full SHA
    afd0638 View commit details
    Browse the repository at this point in the history
  3. Wrap callback in try/finally

    This ensures we clean up always if the callback throws.
    mAAdhaTTah committed Jul 22, 2018
    Copy the full SHA
    094ef31 View commit details
    Browse the repository at this point in the history
  4. Switch Pipeline types to extend NodeBase

    This doesn't work because the `type` values are not compatible.
    mAAdhaTTah committed Jul 22, 2018
    Copy the full SHA
    39e7ee6 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2018

  1. Swap Yoda condition

    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    11aee13 View commit details
    Browse the repository at this point in the history
  2. Remove unneeded comment

    This is no longer true, now that we return `tt.hash`.
    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    d1cae2d View commit details
    Browse the repository at this point in the history
  3. Remove additional parser logic

    These are parsable only in follow-on proposals, not in the base proposal,
    so we'll introduce that in a separate PR.
    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    15e6d84 View commit details
    Browse the repository at this point in the history
  4. Add test for computer properties

    This seems to parse fine. Should it?
    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    ba5642d View commit details
    Browse the repository at this point in the history
  5. Fix error message for babel#4 case

    This impact private fields as well as smart pipeline, providing a clearer
    error message for both.
    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    25d0146 View commit details
    Browse the repository at this point in the history
  6. Verify if MemberExpression is computed

    If a property access is computed, e.g. a[b], then it's in topic style. Currently,
    this isn't accounted for. Test & change ensures this doesn't parse.
    mAAdhaTTah committed Aug 10, 2018
    Copy the full SHA
    122906d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2018

  1. Merge branch 'master' into implement-smart-pipeline-in-parser

    * master: (222 commits)
      Set correct methods name
      Use toPropertyKey in the "decorate" helper
      Allow function types in type params within arrow return types (babel#8954)
      Fix message when plugin of a wrong type is passed (babel#8950)
      rename colliding let bindings with for loop init (babel#8937)
      edge incomplete support for arrow destructuring (babel babel#8349) (babel#8926)
      fix single-arg async arrows when retainLines=true (babel#8868)
      [flow] Explicit inexact objects with `...` (babel#8884)
      Update preset-env data (babel#8898)
      Treat break inside block inside loop (babel#8914)
      fixed "source map" formatting in comment (babel#8878) [skip ci]
      fix typo in contributing guidelines (babel#8901) [skip ci]
      fix: Expression x === 'y' && '' should not evaluate to undefined. (babel#8880)
      fixed an extra word
      Fixes babel#8865 (babel#8866)
      v7.1.4
      v7.1.3
      Bump Babel deps (babel#8770)
      flow-bin@0.82.0 (babel#8832)
      Insertafter jsx fix (babel#8833)
      ...
    
    # Conflicts:
    #	packages/babel-parser/src/tokenizer/index.js
    #	packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-numeric-literal/options.json
    #	packages/babel-parser/test/fixtures/experimental/pipeline-operator/invalid-proposal/options.json
    mAAdhaTTah committed Nov 3, 2018
    Copy the full SHA
    4521204 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b593af1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a0e94ec View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Move plugin check to pipeline op appearance

    No need to recheck it throughout then.
    mAAdhaTTah committed Nov 21, 2018
    Copy the full SHA
    0eb9b24 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6e84352 View commit details
    Browse the repository at this point in the history
  3. s/may/should

    mAAdhaTTah committed Nov 21, 2018
    Copy the full SHA
    70318c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. Hardcode "#" in error message

    It's not going to be anything else...
    mAAdhaTTah committed Nov 22, 2018
    Copy the full SHA
    4cbd22a View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    100b387 View commit details
    Browse the repository at this point in the history