Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private class methods stage 3 #8654

Merged
merged 12 commits into from Nov 29, 2018
Merged

Private class methods stage 3 #8654

merged 12 commits into from Nov 29, 2018

Commits on Nov 26, 2018

  1. Add private method syntax support

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    65cc88f View commit details
    Browse the repository at this point in the history

  2. Add private method spec support

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    0eada24 View commit details
    Browse the repository at this point in the history

  3. Add private method loose support

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    b8c581f View commit details
    Browse the repository at this point in the history

  4. Throw error if static private method is used

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    3c3b039 View commit details
    Browse the repository at this point in the history

  5. Add more isStatic & isMethod checks

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    59cd031 View commit details
    Browse the repository at this point in the history

  6. Remove writable:false from private method inits 

    `writable` is false by default.
    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    6d8b4e4 View commit details
    Browse the repository at this point in the history

  7. Add private method func obj equality check

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    4b6cca8 View commit details
    Browse the repository at this point in the history

  8. Throw if private accessor is used

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    465810c View commit details
    Browse the repository at this point in the history

  9. Add check for fields === private method loose mode

    @tim-mc
    tim-mc committed Nov 26, 2018
    Copy the full SHA
    a84882e View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Throw buildCodeFrameErrors instead of Errors

    @tim-mc
    tim-mc committed Nov 28, 2018
    Copy the full SHA
    3e5f1a4 View commit details
    Browse the repository at this point in the history

  2. Move obj destructuring inside for loop

    @tim-mc
    tim-mc committed Nov 28, 2018
    Copy the full SHA
    2cba230 View commit details
    Browse the repository at this point in the history

  3. Remove "computed" from ClassPrivateMethod type def

    @tim-mc
    tim-mc committed Nov 28, 2018
    Copy the full SHA
    9b0e842 View commit details
    Browse the repository at this point in the history