preset-env: adds dynamic import flag for caller #9057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can work on docs in case this gets merged. |
|
@loganfsmyth and @existentialism: this is a follow up to babel/babel-loader#714. Would you mind reviewing it? |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9423/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9423/ |
|
@thiagoarrais thanks for the PR! as mentioned before, I had a branch with similar code... but we still should discuss logan's point in the original thread: |
|
Closing in favor of #10109 |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interprets the
supportsDynamicImportcaller flag. It was introduced in babel-loader by babel/babel-loader#660 and signals that the target env supports dynamic imports natively.When this gets merged, it should no longer be necessary to manually include the dynamic import syntax plugin in the webpack config. Thus fixing babel/babel-loader#515.
Needs for conclusion:
References: babel/babel-loader#714 (defunct), babel/babel-loader#515