Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow await inside arrow functions #9074

Merged
merged 2 commits into from Nov 26, 2018
Merged

Disallow await inside arrow functions #9074

merged 2 commits into from Nov 26, 2018

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 24, 2018 •
edited

Q                       A
Fixed Issues? Fixes #9071
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This regression was introduced in #7727

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser Spec: Async Functions labels Nov 24, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 24, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9456/

xtuc
xtuc approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@nicolo-ribaudo nicolo-ribaudo merged commit 61f2aed into babel:master Nov 26, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the await-inside-arrow-disallowed branch November 26, 2018 13:12
This was referenced Dec 4, 2018
Merged
Merged
Open
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"await" inside non-async arrow function should throw during parsing
3 participants
@nicolo-ribaudo @babel-bot @xtuc