Skip minifying standalone in non-publish runs #9094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused dependency on uglify js. gulp-uglify uses its own version.
danez
added
the
PR: Internal 🏠
hzoo
approved these changes
Nov 28, 2018
existentialism
approved these changes
Nov 28, 2018
This was referenced Dec 4, 2018
Merged
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only minifies the standalone packages when publishing. We already skipped it on CI, because it is not necessary for the tests. Now it is also skipped in dev unless it is called from publish. I think unless one is working on the standalone packages it is not really necessary to always minify.
Also added a message that states if it is skipped or not.
Also remove unused dependency on uglify js. gulp-uglify uses its own version.