Revert "Revert babel-helper-builder-react-jsx change from #4988" #9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dbc0722. # Conflicts: # packages/babel-helper-builder-react-jsx/src/index.js
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9520/ |
nicolo-ribaudo
approved these changes
Dec 3, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This readds the throw for
JSXSpreadChildin the react transform.It was initially added in #4988 but later reverted (#5015) because there were breaking cases when people used the latest version of the react transform but an older versions of babel-types (which did not yet know the new node
JSXSpreadChild).We now do not have this problem anymore as a) we released a major and b) renamed the project after the node was added.
I thought about adding a flag similar to the namespace flag, but atm if someone would use the react-transform with the SpreacChildren it would throw anyway with: