Types for pipeline operator #9122
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9588/ |
|
@danez @nicolo-ribaudo @xtuc: can you lend an ear here? This is a follow up for #8289. |
| }, | ||
| }); | ||
|
|
||
| defineType("PipelinePrimaryTopicReference", {}); |
There was a problem hiding this comment.
I think that this should still be an expression, since it can safely* moved around.
* It's safe only if it is in the correct context, like it would be for any other identifier reference.
thiagoarrais
changed the title
|
I think my last change finishes this PR. I am marking this as WIP just so that I have chance to clean up the commit history, though. Please let me know if you need anything else. |
|
@thiagoarrais Pretty sure babel team squash/merges so the history should be ok as-is. |
thiagoarrais
force-pushed
the
types-for-smart-pipeline
branch
from
48b880d
to
c7f816b
Compare
thiagoarrais
changed the title
|
Yup. I just want to be nitpicky and remove my temp commits from history. :-) |
|
This is ready to be merged now. |
|
Yes, we usually squash-merge (unless multiple authors worked on the same PR).
Lets just wait for another ✔️ |
lock
bot
added
the
outdated
This is the first of two PRs for implementing the smart pipeline transform. It concentrates on the types and generator code associated with the proposal. As soon as this gets merged, I plan on following up with a PR for the transform itself.
It adds three new types that will be needed for writing the visitor for the transform. I've tried to follow existing conventions. But this is my first PR on this area of the code. So please let me know if anything is out of place. I particularly think this needs an accompanying documentation PR, but I'm not really sure where to make the changes.